This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Add deduplication of source page views #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joellabes
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Seems reasonable! Thanks for submitting the improvement @MarkMacArdle 🙏
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Segment's source table in your warehouse for page views may contain multiple rows for a
page_view_id. I'm seeing rows with the same id andreceived_attimestamps that can differ by up to a week. This was causing two issues:segment_web_page_viewsandsegment_web_page_views_sessionizedwould fail--full-refreshwould allow an update).Adding deduping CTEs fixes these problems. I'm using BigQuery.
Checklist