-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make CLI authentication case-insensitive #100
Comments
@swanderz : That would indeed solve the problem for when authentication type is I have the urge to restructure some code first so that we can add (py)tests. It would make me more confident about changing code without breaking it. However, if we prefer to do a quick fix first, then that is ok with me. |
no urgency to make a hotfix, given that this issue is documented and easily fixed. more tests would be great -- thanks for offering. Happy to add any tests you write to CircleCI. |
in #99, we found out that users assume that
authentication: CLI
can also be given asauthentication: cli
which is not the case.@JCZuurmond... if you're interested 👀
Spitball idea, but maybe we add an
.upper()
to the this snippet below. something like:dbt-sqlserver/dbt/adapters/sqlserver/connections.py
Lines 281 to 288 in 0d529de
The text was updated successfully, but these errors were encountered: