Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add column fix for snapshots and incremental mats #188

Merged
merged 6 commits into from
Nov 30, 2021

Conversation

dataders
Copy link
Collaborator

@dataders dataders commented Nov 30, 2021

fixes: #186
fixes: #177

@dataders dataders changed the title Snapshot add column fix add column fix for snapshots and incremental mats Nov 30, 2021
Copy link

@alieus alieus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment on lines +120 to +132
# - run:
# name: cnxn -- Azure SQL - AZ SP auto
# command: |
# export AZURE_CLIENT_ID="$DBT_AZURE_SP_NAME"
# export AZURE_CLIENT_SECRET="$DBT_AZURE_SECRET"
# export AZURE_TENANT_ID="$DBT_AZURE_TENANT"
# cd test/integration
# dbt compile --target azuresql_azauto
# - run:
# name: cnxn -- Azure SQL - AZ SP env
# command: |
# cd test/integration
# dbt compile --target azuresql_azenv
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled until #189 is resolved

@dataders dataders merged commit 8c6e576 into master Nov 30, 2021
@sdebruyn sdebruyn deleted the snapshot_add_column_fix branch May 17, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapshotting with schema changes doesn't work add sqlserver__alter_relation_add_remove_columns()
2 participants