Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_true_sql function for sqlserver adapter to allow snapshots to… #238

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

jakemcaferty
Copy link
Contributor

Snapshots currently break when adding new columns to SQL Server. A recent update to dbt-core changes the snapshot logic to use an adapter for new columns so that different languages can correctly handle a where clause that is always true.

@jakemcaferty
Copy link
Contributor Author

The specific dbt-core PR that this update will work with is below:
https://github.com/dbt-labs/dbt-core/pull/4871/files

@sdebruyn
Copy link
Member

sdebruyn commented Jun 2, 2022

@jakemcaferty Thank you for your contribution!

@sdebruyn sdebruyn merged commit 6b3b284 into dbt-msft:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants