Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install to directory with spaces #172

Closed
ZSFactory opened this issue Dec 29, 2022 · 4 comments
Closed

Cannot install to directory with spaces #172

ZSFactory opened this issue Dec 29, 2022 · 4 comments
Labels

Comments

@ZSFactory
Copy link

Here is the issue: (I'm using Diskuv Ocaml 1.1.0 on Windows 11)

#=== ERROR while installing cmdliner.1.1.1 ====================================#
# context              2.2.0~alpha0~20221104 | win32/x86_64 | ocaml-system.4.14.0 | pinned(https://erratique.ch/software/cmdliner/releases/cmdliner-1.1.1.tbz)
# path                 C:\Users\Alex Grant\AppData\Local\opam\playground\.opam-switch\build\cmdliner.1.1.1
# command              C:\Users\ALEXGR~1\AppData\Local\Programs\DISKUV~1\bin\WITH-D~1.EXE make install LIBDIR=C:\Users\Alex Grant\AppData\Local\opam\playground\lib\cmdliner DOCDIR=C:\Users\Alex Grant\AppData\Local\opam\playground\doc\cmdliner
# exit-code            2
# env-file             C:\Users\Alex Grant\AppData\Local\opam\log\cmdliner-13664-276e09.env
# output-file          C:\Users\Alex Grant\AppData\Local\opam\log\cmdliner-13664-276e09.out
### output ###
# install -d C:\Users\Alex Grant\AppData\Local\opam\playground\lib\cmdliner
# install: cannot change permissions of 'C:\\Users/Alex': No such file or directory
# make: *** [Makefile:61: create-libdir] Error 1

I believe the fix will be putting quotes around the make install arguments.

cc: @jonahbeckford

@dbuenzli
Copy link
Owner

dbuenzli commented Jan 6, 2023

Thanks for the report. I tried doing what you suggest in e8f8890. Could you please:

opam pin cmdliner --dev

to confirm that it solves the issue.

@heades
Copy link

heades commented Jan 11, 2023

Thanks for the report. I tried doing what you suggest in e8f8890. Could you please:

opam pin cmdliner --dev

to confirm that it solves the issue.

I can confirm that this does indeed work. Thanks for the fix!

@ZSFactory
Copy link
Author

Thanks for the report. I tried doing what you suggest in e8f8890. Could you please:

opam pin cmdliner --dev

to confirm that it solves the issue.

Yes this works. Thank you for the fix!
Apologies for the later response.

@dbuenzli
Copy link
Owner

Cool no problem, thanks to both. I'll push a release in the upcoming days.

@dbuenzli dbuenzli added the bug label Jan 13, 2023
emillon pushed a commit to ocaml-dune/cmdliner that referenced this issue Sep 25, 2023
emillon pushed a commit to ocaml-dune/cmdliner that referenced this issue Sep 25, 2023
Signed-off-by: Etienne Millon <me@emillon.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants