-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
META: gg.top should depend on gg #1
Comments
You've got things the wrong way around, see this line. Just
|
Oops. Sorry for the noise. |
@whitequark Actually I think that what you assumed maybe the right thing to do. The problem with my current toplevel scheme, is that I don't give the choice to people. If they So I think it would be better if What do you think ? |
@dbuenzli I think the scheme you propose is much more clear for the users. I certainly like it more; a package shouldn't behave differently when loaded in toplevel and when not. |
@whitequark Yes. I'm going to gradually change that in my distributed packages. |
Subject says it. I don't think there is a reason to require gg.top but not gg, and adding a dependency means one #require less.
The text was updated successfully, but these errors were encountered: