Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name with space makes arduino-cli awkward #48

Closed
majenkotech opened this issue Aug 30, 2020 · 3 comments
Closed

Package name with space makes arduino-cli awkward #48

majenkotech opened this issue Aug 30, 2020 · 3 comments

Comments

@majenkotech
Copy link

Having the global package name "LGT8fx Boards" in the packages .json file makes it awkward to use arduino-cli. All boards, and the core itself, get an awkward name that has a space in it, making escaping that space a pain, and not simple to do in a platform-agnostic way.

$ arduino-cli board listall | grep -i lgt8
LGT8F328                                    LGT8fx Boards:avr:328                         
LGT8F88                                     LGT8fx Boards:avr:88                   

Ideally the package name should be just lgt8fx which results in the much easier to use:

$ arduino-cli board listall | grep -i lgt8
LGT8F328                                    lgt8fx:avr:328                                
LGT8F88                                     lgt8fx:avr:88  

You still get the "pretty" name of the core in the platform name:

$ arduino-cli core search lgt8fx
ID         Version Name         
lgt8fx:avr 1.0.6   LGT8fx Boards

No other core has a space in its name - and for good reason: it's a right pain if there is a space.

@dbuezas
Copy link
Owner

dbuezas commented Sep 9, 2020

Thanks for the issue,
I'll change the name in the json in the next release (to LGT8fx)

@dwillmore
Copy link
Collaborator

Did this actually get fixed in the next release?

@dbuezas
Copy link
Owner

dbuezas commented Jan 12, 2023

It looks like I had "fixed" it wrong in the build script. Fixing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants