📝 zb: update documentation for Guid::generate #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
book-1.0 is about 1.0 API so it should have that ref. I'll be removing the book-1.0 anyway as part of the upcoming 4.0 release. |
|
@alyssais don't sweat the CI failure, it's caused by rust-lang/rust-clippy#12133 which was fixed 2 days ago so as soon as clippy nightly has it, the CI will go green and we can merge. |
|
@alyssais I added a workaround for the clippy issue. Could you please rebase on main branch? Then we can get this merged. |
Connection::new_unix_server no longer exists, so I've replaced it with the appropriate current method.
auto-merge was automatically disabled
January 15, 2024 20:51
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection::new_unix_server no longer exists, so I've replaced it with the appropriate current method.
There's also a reference to this method in book-1.0, but I wasn't sure whether that should be updated.