zvariant: Fix compilation of gvariant feature on non-unix platforms #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
approved these changes
Feb 22, 2024
felinira
added a commit
to felinira/gvdb-rs
that referenced
this pull request
Feb 22, 2024
Requires a release with dbus2/zbus#651
|
Thanks so much @felinira . We should enable gvariant testing on Windows CI so these things don't happen. |
|
@felinira btw, for future contributions, kindly add emoji prefixes to the commits and make use of abbreviated crate name, as per our contributing guidelines. |
felinira
added a commit
to felinira/gvdb-rs
that referenced
this pull request
Feb 23, 2024
Requires a release with dbus2/zbus#651
felinira
added a commit
to felinira/gvdb-rs
that referenced
this pull request
Feb 23, 2024
Requires a release with dbus2/zbus#651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fail compilation on eg. windows because the FD generic does not actually exist there.
Reproduce via
cargo build --features="gvariant" --target=x86_64-pc-windows-gnu