You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm going to file this issue preemptively, because we are changing the way dc.js loads crossfilter and it is going to break requireJS and other AMD package loaders.
https://github.com/crossfilter/crossfilter, the community fork of crossfilter, has a different filename (crossfilter.js) from its module name (crossfilter2). But requireJS (and presumably other AMD loaders) assumes that the module name will be the same as the filename.
From dc.js 2.0.3 and 2.1.5 onward, index.js and the UMD footer of dc.js will refer to the module name crossfilter2 instead of crossfilter.
requireJS users will need to rename crossfilter.js to crossfilter2.js when copying it into position, or use the requireJS paths, or map configuration options to specify that the filename is different from the module name.
this breaks requireJS but fixes webpack - since the community fork of
crossfilter has a different package name from its filename, one or the
other packaging system is going to be unhappy.
requireJS users will need to rename crossfilter.js to crossfilter2.js
when copying it into position, or use the requireJS paths or map
configuration options to specify that the filename is different from the
module name.
http://requirejs.org/docs/api.html#config-pathshttp://requirejs.org/docs/api.html#config-mapfixes#1213fixes#1214fixes#1261fixes#1293fixes#1302
breaks #1304!
Yes, the problem was that some webpack based projects e.g. angular-cli did not permit changing the config at all. Whereas requireJS is always open for configuration afaik.
I'm going to file this issue preemptively, because we are changing the way dc.js loads crossfilter and it is going to break requireJS and other AMD package loaders.
https://github.com/crossfilter/crossfilter, the community fork of crossfilter, has a different filename (
crossfilter.js
) from its module name (crossfilter2
). But requireJS (and presumably other AMD loaders) assumes that the module name will be the same as the filename.From dc.js 2.0.3 and 2.1.5 onward,
index.js
and the UMD footer ofdc.js
will refer to the module namecrossfilter2
instead ofcrossfilter
.requireJS users will need to rename
crossfilter.js
tocrossfilter2.js
when copying it into position, or use the requireJS paths, or map configuration options to specify that the filename is different from the module name.http://requirejs.org/docs/api.html#config-paths
http://requirejs.org/docs/api.html#config-map
For further discussion, please see crossfilter/crossfilter#75
The text was updated successfully, but these errors were encountered: