-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elasticX(true) on Composite breaks rangeChart zooming #987
Comments
Okay so beta.9 pushed the elasticX() from the parent chart down to it's children. As you can see here focus will be ignored if elasticX is set to true. |
Ah ok that makes sense. It should just be mentioned in the API docs. And/or setting elasticX on composite charts should not be available then, or generate an error. |
We could probably generate a warning of some sort and it should definitely be in the docs. I don't see why it would be disabled though since some people use composite charts without range charts. |
I don't understand. What's the use case for a focus chart with Or alternately, is there a use case where some of the subcharts are elasticX but others are not? Don't they always share the X axis? I think I must be missing something here. |
I think you are right, I can't really think of a use-case. |
I guess it could be useful to have the first render use elasticX, and then subsequently just get the domain from the range chart. |
Okay, I'll consider this a documentation issue: the fact that |
If
elasticX(true)
is enabled on a composite chart, connected to a rangeChart, it breaks rangeChart zooming. SettingelasticX(false)
"fixes" the behavior.The bug first occurs in
beta.9
.jsfiddle: https://jsfiddle.net/ocxxuyL5/1/
The text was updated successfully, but these errors were encountered: