Bubble Chart: selectAll should be select when manipulating a enter/update selection #1237
Conversation
|
Yes, #1032 is the previous issue. And you found similar problems in four other charts. So I guess we are not testing updates of at least these six charts. 😱 |
|
It's not that we don't test update. It's that the code currently works as long as the data is updated in-place, as crossfilter always does. But we definitely shouldn't assume that. On a hunch, I created a (rather excessive) bl.ock demonstrating the problem: Everything is fine with the top two charts, which use straight crossfilter. But in the second two charts we clone the keys and values each time |
for #1237 also, new iris test fixture
|
added test and merging for 2.0 - thanks @mtraynham! |
for #1237 this tests the bubble mixin
honest, it's not just to puff up my test count it's to make it clear these are all separate functions being tested for #1237
selectAllin these cases is going to screw up the current enter/update selection, which results in some nodes not getting updated. These should really beselect. I feel like this has come up before, but I can't seem to find the particular PR or conversation about it.