Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing fade deselected. Possible fix of #1401 #1422

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 3.0.0 alpha 12
* fadeDeselectedArea checks if brushing is enabled for the chart. Restores backward compatibility. By Deepak Kumar. ([#1422](https://github.com/dc-js/dc.js/pull/1422))

## 3.0.0 alpha 11
* xAxisPaddingUnit should be the d3 interval not the name of it ([#1320](https://github.com/dc-js/dc.js/issues/1320), [#1326](https://github.com/dc-js/dc.js/issues/1326), [#1420](https://github.com/dc-js/dc.js/issues/1420))

Expand Down
44 changes: 0 additions & 44 deletions D3v4-Upgrade-Notes.md

This file was deleted.

3 changes: 3 additions & 0 deletions src/bar-chart.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,9 @@ dc.barChart = function (parent, chartGroup) {
}

_chart.fadeDeselectedArea = function (selection) {
if (!_chart.brushOn()) {
return;
}
var bars = _chart.chartBodyG().selectAll('rect.bar');

if (_chart.isOrdinal()) {
Expand Down
3 changes: 3 additions & 0 deletions src/box-plot.js
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ dc.boxPlot = function (parent, chartGroup) {
}
});
} else {
if (!_chart.brushOn()) {
return;
}
var start = selection[0];
var end = selection[1];
var keyAccessor = _chart.keyAccessor();
Expand Down