Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding the data object rather than its parent to pieChart's title fu... #757

Closed
wants to merge 2 commits into from

Conversation

r4j4h
Copy link
Contributor

@r4j4h r4j4h commented Nov 11, 2014

...nction in reference to issue #755

@r4j4h
Copy link
Contributor Author

r4j4h commented Nov 11, 2014

Oh d'oh, I did not build or look into testing the change... still waiting on npm install to finish hehe

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Nov 30, 2014
* master: (57 commits)
  artifacts; update stock fixture
  update version
  more churn
  will the doc artifact churn never end?
  more doc artifacts
  artifacts from updated documentation tools
  grow bars upward
  propagate transition duration to d3.behavior.zoom object
  update stock fixture
  also test for exactly one title per dot
  remove extra `fill`
  add test for dc-js#742
  remove superfluous redraw
  add missing emails to AUTHORS
  add recently-merged PR authors
  update doc to match dc-js#744
  artifacts
  s/object/function/
  artifacts
  add optional selector argument to dc.utils.appendOrSelect
  ...
@r4j4h
Copy link
Contributor Author

r4j4h commented Jan 5, 2015

Hmm, I wonder how GitHub would handle me moving this commit back so that I can rebase instead of the merge... easy enough to do it in another branch, but I'm gonna experiment on this one to see if we can salvage it.

@r4j4h
Copy link
Contributor Author

r4j4h commented Jan 5, 2015

For reference, I deleted the branch and re-pushed it one commit back (the merge commit). GitHub automatically closed the Issue. Although the branch is now there and a new issue was successfully created, this one is unable to be reopened with a tool tip dialog stating that the branch was force-pushed or recreated.

So good behavior, but I think it would be even nicer if it would let us just kind of "clear out" and re-purpose this one.

@gordonwoodhull
Copy link
Contributor

Weird, I'm surprised by that. Pretty sure I have done that in the past. Oh well,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants