Skip to content
This repository has been archived by the owner on Dec 30, 2023. It is now read-only.

Display window for choropleth map #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

KatiRG
Copy link

@KatiRG KatiRG commented Oct 7, 2015

Values for choropleth map displayed in a window in upper right of the map.
Adapted from http://leafletjs.com/examples/choropleth.html.

Big thanks to @akurniko for getting it to work!

@gordonwoodhull
Copy link

Thanks! This will help a lot.

Hmm, it looks like you're following a different directory structure, closer to Boyan's. I should be able to sort it out, but if you feel like adapting your work to fit better, the idea is to generate dc.leaflet.js from the files in src/ using grunt. The demo now lives in web/ and its dependencies in web/js.

In any case, it's not a big deal for me to pull the parts I like and rework them to fit. I'm not the kind of maintainer who just presses the big Merge button. (Unfortunately my turnaround rate can be a bit slow because I'm careful.)

@KatiRG
Copy link
Author

KatiRG commented Oct 9, 2015

OK, I have rearranged the directory structure. There are only two files that relate to this PR: web/index.html which contains the css for the map window, and dc.leaflet.js which I put in both web/js and the main directory. I haven't generated any of the derived files though (dc.leaflet.js.map, dc.leaflet.min.js.map, etc) since I'm not sure how this is done. If you want me to do that, I can try. Please let me know if I should do anything else. Thanks for your help!

@KatiRG KatiRG force-pushed the window branch 2 times, most recently from 7a352ac to 3b5e732 Compare October 19, 2015 21:46
@gordonwoodhull
Copy link

I reviewed this again because I was wondering why I never merged this. It looks super useful.

If anyone wants to push this forward, the changes should be applied to the individual files inside src/, instead of the generated artifact dc.leaflet.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants