Multi file support + Dependency graph ordering #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For generating larger projects it may be desirable to generate into different files. Now --input can take a directory. If it is given a directory it will read all .cddl files and generate each in its own .rs file for export. Serialization/*Encodings are still all in one file.
cddl doesn't support parsing incomplete cddl strings so will error on some inputs. This works around it by merging it into 1 file with scope markers then using those instead to mark scope.
|
I'll combine the dep graph stuff into this if we can't get this merged before that is completed (likely today, or if not, tomorrow). They're both kind of related anyway, since for large |
| // This approeach was chosen over comments as those were finicky when not attached | ||
| // to specific structs, and the existing comment parsing ast was not suited for this. | ||
| // If, in the future, cddl released a feature flag to allow partial cddl we can just | ||
| // remove all this and revert back the commit before this one for scope handling. |
Fixes #93 This is extra important with multi file support now, as it can be impossible in some cases to order things properly when the circular dependencies were across multiple files. Now `babbage.cddl` processes totally fine even when separated across many files. This commit also includes some fixes for multi file support with inter-file dependencies (e.g. fixes for visibility/module use/etc).
rooooooooob
changed the title
rooooooooob
commented
Oct 6, 2022
SebastienGllmt
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For generating larger projects it may be desirable to generate into different files. Now --input can take a directory. If it is given a directory it will read all .cddl files and generate each in its own .rs file for export. Serialization/*Encodings are still all in one file. This resolves #95
Also includes dependency graph ordering that fixes #93 and is essential for multi file support where the cyclic references are across file boundaries. This should also fix #98