.cbor spec support #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports `bytes .cbor T` which allows encoding bytes that must obey the format of a serialized `T`. This is supported both in fields and definitions. In the generated API any `bytes .cbor T` is treated as `T` but in the serialization code it is treated as bytes. Also removes the need to generate wrapper types for tagged types and instead only uses aliases as they are essentially only a serialization detail. Includes a fix for the unit tests core/core_no_wasm as there was a low chance of them failing as the tests seem to be run asynchronously which could allow one of them to rarely have unit tests copied twice. This replaces the PR #47 to avoid a bunch of git merging issues due to it being based partway through #37 before it was merged and in a fork.
SebastienGllmt
approved these changes
Aug 3, 2022
This was referenced Aug 26, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports
bytes .cbor Twhich allows encoding bytes that must obey theformat of a serialized
T. This is supported both in fields anddefinitions. In the generated API any
bytes .cbor Tis treated asTbut in the serialization code it is treated as bytes.
Also removes the need to generate wrapper types for tagged types and
instead only uses aliases as they are essentially only a serialization
detail.
Includes a fix for the unit tests core/core_no_wasm as there was a low
chance of them failing as the tests seem to be run asynchronously which
could allow one of them to rarely have unit tests copied twice.
This replaces the PR #47 to avoid a bunch of git merging issues due to
it being based partway through #37 before it was merged and in a fork.