Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature improvements #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

heyx3
Copy link

@heyx3 heyx3 commented Mar 27, 2015

I work for a company that wanted to use this project, and in the process of integrating it, I've managed to clean up some parts of it. I figured I'd submit the changes back to the original repo.

The things this PR changes are:

  • Removed the .meta files, which would only be useful if some of these scripts were MonoBehaviours and those MonoBehaviours were used in a Prefab/GameObject somewhere in the repo.
  • Removed the commented-out python code (and some commented-out C# code, mainly debug outputs).
  • Changed the sample .projmods file to have a ".projmods.sample" extension. When I first used this repo, I was unknowingly using this file along with the .projmods file I intended to use, simply because i didn't realize it was sitting in the repo. With this new extension, there's no risk of somebody else making the same mistake.
  • It seems like some files and lines of code weren't actually used, so I removed them.

@dcariola
Copy link
Owner

Thanks for the support, I'll review the pull request asap

@Mehul24
Copy link

Mehul24 commented Mar 15, 2016

Is this getting merged anytime soon? Would love to merge in the cleaned version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants