-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark reporting to PRs and commits #455
Conversation
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
It's working, but look like - we cannot see performance details. I will try to use vitest integration. Maybe it will help |
I feel that I need to add benchmarks without cache. Because now we are benchmarking LRUCache performance. It's ok, but I do not think that's what we want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the great work! I added some comments about some minor stuff and a bigger one regarding the caching.
Could you address those?
it works locally, but do not work with plugin xD |
It seems like of ci codespeed calls function only once to measure performance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
It seems like of ci codespeed calls function only once to measure performance
But I am no sure
We'll figure it out as we go. After a few other PRs it will be easier to tell whether something is off. I'll also play around a bit with it.
Closes #253