chore(did-provider-pkh): apply suggestions from code review

dchagastelles · Feb 7, 2023 · 4dd14b9 · 4dd14b9
1 parent 6a08e73
commit 4dd14b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/did-provider-pkh/src/pkh-did-provider.ts b/packages/did-provider-pkh/src/pkh-did-provider.ts
@@ -11,7 +11,7 @@ import {
 import { AbstractIdentifierProvider } from '@veramo/did-manager';
 import Debug from 'debug'
 
-const debug = Debug('veramo:data-store:migrate-presentation-issuance-date')
+const debug = Debug('veramo:pkh-did-provider')
 
 type IContext = IAgentContext<IKeyManager>;
 
@@ -103,7 +103,7 @@ export class PkhDIDProvider extends AbstractIdentifierProvider {
       return identifier;
     } else {
       debug('Could not create identifier due to some errors');
-      throw new Error('Could not create identifier due to some errors');
+      throw new Error('unknown_error: could not create identifier due to errors creating or importing keys');
     }
   }
 

diff --git a/packages/did-provider-pkh/src/resolver.ts b/packages/did-provider-pkh/src/resolver.ts
@@ -7,7 +7,9 @@ import type {
   ResolverRegistry,
 } from 'did-resolver';
 import { isValidNamespace, SECPK1_NAMESPACES } from './pkh-did-provider';
+import Debug from 'debug'
 
+const debug = Debug('veramo:pkh-did-resolver')
 const DID_LD_JSON = 'application/did+ld+json';
 const DID_JSON = 'application/did+json';
 
@@ -37,7 +39,7 @@ function toDidDoc(did: string, blockchainAccountId: string): any {
     assertionMethod: [vmId],
   };
   if (!isValidNamespace(namespace)) {
-    console.error(
+    debug(
       `Invalid namespace '${namespace}'. Valid namespaces are: ${SECPK1_NAMESPACES}`
     );
     throw new Error(