Do not pass ParticipantNodes via protobuf for local event.

dcherednik · Jan 23, 2025 · 73b3112 · 73b3112
1 parent bd79c91
commit 73b3112
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 10 deletions.
diff --git a/ydb/core/kqp/executer_actor/kqp_executer.h b/ydb/core/kqp/executer_actor/kqp_executer.h
@@ -34,6 +34,8 @@ struct TEvKqpExecuter {
         ui64 ResultRowsCount = 0;
         ui64 ResultRowsBytes = 0;
 
+        THashSet<ui32> ParticipantNodes;
+
         enum class EExecutionType {
             Data,
             Scan,

diff --git a/ydb/core/kqp/executer_actor/kqp_executer_impl.h b/ydb/core/kqp/executer_actor/kqp_executer_impl.h
@@ -1897,6 +1897,8 @@ class TKqpExecuterBase : public TActor<TDerived> {
     void PassAway() override {
         YQL_ENSURE(AlreadyReplied && ResponseEv);
 
+        ResponseEv->ParticipantNodes = std::move(ParticipantNodes);
+
         // Fill response stats
         {
             auto& response = *ResponseEv->Record.MutableResponse();
@@ -1923,10 +1925,6 @@ class TKqpExecuterBase : public TActor<TDerived> {
                     LOG_I("Full stats: " << response.GetResult().GetStats());
                 }
             }
-
-            for (const auto nodeId : ParticipantNodes) {
-                response.MutableResult()->AddParticipantNodes(nodeId);
-            }
         }
 
         Request.Transactions.crop(0);

diff --git a/ydb/core/kqp/session_actor/kqp_query_state.h b/ydb/core/kqp/session_actor/kqp_query_state.h
@@ -170,7 +170,7 @@ class TKqpQueryState : public TNonCopyable {
     ui32 StatementResultSize = 0;
 
     TMaybe<TString> CommandTagName;
-    THashSet<uint32_t> ParticipantNodes;
+    THashSet<ui32> ParticipantNodes;
 
     bool IsLocalExecution(ui32 nodeId) const {
         if (RequestEv->GetRequestCtx() == nullptr) {

diff --git a/ydb/core/kqp/session_actor/kqp_session_actor.cpp b/ydb/core/kqp/session_actor/kqp_session_actor.cpp
@@ -1554,10 +1554,8 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
             QueryState->QueryStats.Executions.back().Swap(executerResults.MutableStats());
         }
 
-        if (executerResults.ParticipantNodesSize()) {
-            for (auto nodeId : executerResults.GetParticipantNodes()) {
-                QueryState->ParticipantNodes.emplace(nodeId);
-            }
+        for (auto nodeId : ev->ParticipantNodes) {
+            QueryState->ParticipantNodes.emplace(nodeId);
         }
 
         if (response->GetStatus() != Ydb::StatusIds::SUCCESS) {

diff --git a/ydb/core/protos/kqp.proto b/ydb/core/protos/kqp.proto
@@ -446,7 +446,6 @@ message TExecuterTxResult {
     reserved 5; // (deprecated) Stats
     optional NYql.NDqProto.TDqExecutionStats Stats = 6;
     reserved 7;
-    repeated uint32 ParticipantNodes = 8;
 };
 
 message TExecuterTxResponse {