Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nacl.sealedbox(msg, nonce, publicKey)
andnacl.sealedbox.open(msg, nonce, secretKey)
tonacl.js
andnacl-fast.js
nacl.js
andnacl-fast.js
:checkSealedBoxLengths(sk, n, m)
to check lengths of a secret key, nonce, and message fornacl.sealedbox.open
tonacl.js
andnacl-fast.js
Although there is a third-party library adding support for sealed boxes, there are a few reasons why I think it would be a good idea to include an implementation directly in
TweetNaCl.js
:Uint8Array
filled with0
s (see libsodium #630). It would be better to allow developers to choose the nonce directly for added flexibility, even though my implementation generates ephemeral keys within the scope of the function and zeroes out the secret key after boxing (low risk of reusing the ephemeral key).TweetNaCl.js
library so that developers do not have to hunt down other libraries and so that companies do not have to add more dependencies to audit. The third-party library is not only just an extra dependency, it is not self-contained and relies onblakejs
to generate the nonce (unnecessary as described above).@dchest Please let me know if you plan to merge this PR. If so, I can write some test cases and add documentation to the
README.md
.