-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled writing of location and description in DICOM SR file #228
base: master
Are you sure you want to change the base?
Enabled writing of location and description in DICOM SR file #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add these concepts be we need to be sure they are coded correctly. Please have a look at what I linked or if you have a rationale for what you picked please and a description with links to the standard for reference.
Also the commit message should start with something like "feat(tid300):" to trigger the semantic release.
CodeValue: "112041", | ||
CodingSchemeDesignator: "DCM", | ||
CodeMeaning: "Location" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a link to the definition of this code?
From this document it seems that this code means "Target Lesion Complete Response".
http://dicom.nema.org/medical/dicom/current/output/chtml/part16/chapter_D.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we want to use "121226 Approximate spatial location"
"The approximate geometric location on an image or in space where an entity is located."
CodeValue: "112042", | ||
CodingSchemeDesignator: "DCM", | ||
CodeMeaning: "Description" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly this one appears to mean "Target Lesion Partial Response"
No description provided.