Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Fix assert failure in rollup #415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pieper
Copy link
Collaborator

@pieper pieper commented Dec 18, 2024

Due to change in nodejs, as described here:

rollup/rollup#5531

Before this fix:

% npm run build

> dcmjs@0.30.0 build
> rollup -c

[!] SyntaxError: Unexpected identifier 'assert'
    at compileSourceTextModule (node:internal/modules/esm/utils:338:16)
    at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:102:18)
    at ModuleLoader.#translate (node:internal/modules/esm/loader:437:12)
    at ModuleLoader.loadAndTranslate (node:internal/modules/esm/loader:484:27)
    at ModuleJob._link (node:internal/modules/esm/module_job:115:19)

Due to change in nodejs, as described here:

rollup/rollup#5531

Before this fix:
```
% npm run build

> dcmjs@0.30.0 build
> rollup -c

[!] SyntaxError: Unexpected identifier 'assert'
    at compileSourceTextModule (node:internal/modules/esm/utils:338:16)
    at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:102:18)
    at ModuleLoader.#translate (node:internal/modules/esm/loader:437:12)
    at ModuleLoader.loadAndTranslate (node:internal/modules/esm/loader:484:27)
    at ModuleJob._link (node:internal/modules/esm/module_job:115:19)

```
@pieper pieper requested a review from wayfarer3130 December 18, 2024 18:35
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for dcmjs2 failed.

Name Link
🔨 Latest commit 7f6d25b
🔍 Latest deploy log https://app.netlify.com/sites/dcmjs2/deploys/676315eda9c3cb000802d841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant