checks for both commit.author and commit.committer #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bex Warner <bexmwarner@gmail.com>
gr2m
added a commit
that referenced
this pull request
Nov 9, 2021
I think that we actually should review the `const email = commit.author.email || commit.committer.email` code. I think we should validate both emails explicitly instead of only verifying the committer email if author email is not set. I do not even know if that is possible at all
gr2m
added a commit
that referenced
this pull request
Nov 9, 2021
I think that we actually should review the `const email = commit.author.email || commit.committer.email` code. I think we should validate both emails explicitly instead of only verifying the committer email if author email is not set. I do not even know if that is possible at all Signed-off-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
gr2m
added a commit
that referenced
this pull request
Nov 9, 2021
I think that we actually should review the `const email = commit.author.email || commit.committer.email` code. I think we should validate both emails explicitly instead of only verifying the committer email if author email is not set. I do not even know if that is possible at all Signed-off-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
gr2m
added a commit
that referenced
this pull request
Nov 16, 2021
I think that we actually should review the `const email = commit.author.email || commit.committer.email` code. I think we should validate both emails explicitly instead of only verifying the committer email if author email is not set. I do not even know if that is possible at all Signed-off-by: Gregor Martynus <39992+gr2m@users.noreply.github.com>
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally closes #39 in checking the sign off against
commit.authorandcommit.committervaluesfeedback welcome on the implementation, wasn't sure what a better way would be