Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config options for setting Admin Router gRPC port #37

Open
wants to merge 1 commit into
base: support/0.2.x
Choose a base branch
from
Open

Add config options for setting Admin Router gRPC port #37

wants to merge 1 commit into from

Conversation

vespian
Copy link
Collaborator

@vespian vespian commented Mar 5, 2020

This PR adds support for Add config options for setting Admin Router gRPC port. See the Jira issue below for more details:

https://jira.d2iq.com/browse/D2IQ-62476

@vespian vespian requested review from sebbrandt87 and fatz March 5, 2020 17:18
@vespian vespian self-assigned this Mar 5, 2020
wavesoft
wavesoft approved these changes Apr 2, 2020
View reviewed changes
Copy link

@wavesoft wavesoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wavesoft wavesoft wavesoft approved these changes

@sebbrandt87 sebbrandt87 Awaiting requested review from sebbrandt87

@fatz fatz Awaiting requested review from fatz

At least 1 approving review is required to merge this pull request.

Assignees

@vespian vespian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vespian @wavesoft