Skip to content

Commit

Permalink
fix(PackageDetailTab): update version dropdown layout per design request
Browse files Browse the repository at this point in the history
Updated the layout and styling to match the design Lee suggested

Closes DCOS-19295
  • Loading branch information
mperrotti authored and nLight committed Feb 19, 2019
1 parent c16fd0b commit c8e1207
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/js/pages/catalog/PackageDetailTab.js
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ class PackageDetailTab extends mixin(StoreMixin) {

return (
<Dropdown
buttonClassName="button button-link dropdown-toggle"
buttonClassName="button button-primary-link dropdown-toggle flush-left flush-right"
dropdownMenuClassName="dropdown-menu"
dropdownMenuListClassName="dropdown-menu-list"
onItemSelection={this.handlePackageVersionChange}
Expand Down Expand Up @@ -517,8 +517,11 @@ class PackageDetailTab extends mixin(StoreMixin) {
</div>
{!state.isLoadingSelectedVersion && (
<div className="media-object-item media-object-item-grow ">
<div className="flex flex-direction-left-to-right">
<h1 className="short flush-top">{name}</h1>
<h1 className="short flush-top flush-bottom">{name}</h1>
<div className="flex flex-align-items-center">
<span className="package-version-label">
<Trans>Version</Trans>:
</span>
{this.getPackageVersionsDropdown()}
</div>
<div className="row">
Expand Down
4 changes: 4 additions & 0 deletions src/styles/views/packages/styles.less
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
margin-right: @base-spacing-unit * 1/4;
}
}

.package-version-label {
padding-right: @base-spacing-unit * 1/4;
}
}

& when (@packages-view-enabled) and (@layout-screen-small-enabled) {
Expand Down

0 comments on commit c8e1207

Please sign in to comment.