fix(docker-compose): fix yml to use mapping instead of list #2558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
further reading:
docker/compose#2854
https://docs.docker.com/compose/compose-file/#args
this PR unblocks #2547 - rebase it on this one and it should run successfully when run throughwe decided to merge #2547 before this one because the tests are running on ci, only our localdocker-compose exec toolchain dcos-system-test-driver /dcos-ui/system-tests/driver-config/jenkins.sh
docker-compose
setup is broken.HINT: you can prevent the cluster (and tests) from being started with adding
exit 1
in the first line ofsystem-tests/_scripts/launch-cluster.sh
- it will fail withProcess '../_scripts/launch-cluster.sh' exited with 1
which is okay and means the config is correctly parsed.if you see the error @nLight mentioned in #2547 it didnt work.
Caveat: it looks like docker doesnt recognize when you change the passed variables afterhad todocker-compose up -d
🤔export
the changed var…