Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zk leader fix #285

Merged
merged 8 commits into from
Oct 26, 2018
Merged

zk leader fix #285

merged 8 commits into from
Oct 26, 2018

Conversation

kensipe
Copy link
Contributor

@kensipe kensipe commented Oct 25, 2018

zk leader fix

Summary:
It seemed important to get the startup race condition out of the picture... so I added that to this work. What is left is to add in marathon code from: mesosphere/marathon@db9dda9

https://jira.mesosphere.com/browse/DCOS-41408

It is also believed that this will fix: https://jira.mesosphere.com/browse/DCOS_OSS-3616

JIRA issues: DCOS-41408, DCOS_OSS-3616

@kensipe kensipe added the WIP label Oct 25, 2018
Copy link
Collaborator

@timcharper timcharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this wasn't a fun change to make. I looked and understand why you had to copy so much code.

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a significant metronome initialization change, please make sure Metronome starts (and ideally passes SI tests) before we merge

Otherwise 👍

@kensipe kensipe merged commit 9f60bba into releases/0.4 Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants