Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cron-utils to 9.0.0 the latest release #346

Merged
merged 4 commits into from
Jul 3, 2019
Merged

Conversation

kensipe
Copy link
Contributor

@kensipe kensipe commented Jul 2, 2019

Summary:
There are a number of bugs fixed between 7.0.5 to 9.0.0. The most significant is the infinite loop bug for midnight DST: jmrozanec/cron-utils#333

It is confusing why we are still using threeten-bp. It was originally required for cron-utils but isn't now. I've completely removed it. We previously were on 1.3.3 (released in 2016). There were a number of fixes up to the latest 1.4.0 version https://www.threeten.org/threetenbp/changes-report.html#a1.4.0.
At this point, it isn't necessary and removes a point of failure to eliminating it.

JIRA issues:

Copy link
Collaborator

@mesosphere-ci mesosphere-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm building your change at jenkins-Metronome-metronome-pipelines-PR-346-2.

Copy link
Collaborator

@mesosphere-ci mesosphere-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✗ Build of #346 failed.

See the logs and test results for details.

Error message:

Stage Compile and Test failed.

(๑′°︿°๑)

@kensipe
Copy link
Contributor Author

kensipe commented Jul 2, 2019

also... did I mention that it is tiring seeing this flake in our CI all the time?

+ bin/install-protobuf.sh
Linux
bin/install-protobuf.sh: 10: [: Linux: unexpected operator
E: Could not get lock /var/lib/dpkg/lock - open (11: Resource temporarily unavailable)
E: Unable to lock the administration directory (/var/lib/dpkg/), is another process using it?
script returned exit code 100```

Copy link
Collaborator

@mesosphere-ci mesosphere-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm building your change at jenkins-Metronome-metronome-pipelines-PR-346-4.

Copy link
Collaborator

@mesosphere-ci mesosphere-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Build of #346 completed successfully.

See details at jenkins-Metronome-metronome-pipelines-PR-346-4.

You can create a DC/OS with your patched Metronome by creating a new pull
request with the following changes in buildinfo.json:

"url": "https://s3.amazonaws.com/downloads.mesosphere.io/metronome/builds/0.6.35-bccb59b/metronome-0.6.35-bccb59b.tgz",
"sha1": "5d12cb57315504bdabda8c7f29dec21dc0f7db23"

\\ ٩( ᐛ )و //

Copy link
Collaborator

@mesosphere-ci mesosphere-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm building your change at jenkins-Metronome-metronome-pipelines-PR-346-5.

Copy link
Collaborator

@mesosphere-ci mesosphere-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Build of #346 completed successfully.

See details at jenkins-Metronome-metronome-pipelines-PR-346-5.

You can create a DC/OS with your patched Metronome by creating a new pull
request with the following changes in buildinfo.json:

"url": "https://s3.amazonaws.com/downloads.mesosphere.io/metronome/builds/0.6.36-05fee06/metronome-0.6.36-05fee06.tgz",
"sha1": "2c24dbb9de6e7ac577265a5eb5af1ab9c7d248e6"

\\ ٩( ᐛ )و //

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kensipe kensipe merged commit b28106a into master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants