Don't mutate user settings

Fixes GoogleChrome#1067 Closes GoogleChrome#1022
dcsaszar · Aug 3, 2024 · e31ed5b · e31ed5b
1 parent 2cb0d07
commit e31ed5b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/cli/src/collect/node-runner.js b/packages/cli/src/collect/node-runner.js
@@ -42,7 +42,7 @@ class LighthouseRunner {
  * @return {{args: string[], cleanupFn: () => void}}
  */
  static computeArgumentsAndCleanup(url, options) {
- const settings = options.settings || {};
+ const settings = {...options.settings};
  const chromeFlags = options.settings && options.settings.chromeFlags;
  let chromeFlagsAsString = chromeFlags || '';
  if (!options.headful) chromeFlagsAsString += ' --headless=new';