Add Immutable Dispatcher #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcsg
force-pushed
the
implement-immutable-dispatcher
branch
4 times, most recently
from
782115a
to
b4d2aaf
Compare
dcsg
force-pushed
the
implement-immutable-dispatcher
branch
from
b4d2aaf
to
4e187f9
Compare
dcsg
force-pushed
the
implement-immutable-dispatcher
branch
from
14b8b6b
to
e692575
Compare
ivoanjo
reviewed
Jul 14, 2017
| context 'when one listener is provided' do | ||
| let(:listeners) { | ||
| [ | ||
| { event_name: event_name, listener: listener, listener_method: listener_method, priority: priority }, |
There was a problem hiding this comment.
Minor 💅, there should be no space after { and before }, as this is a hash, not a block.
There was a problem hiding this comment.
I guess rubocop will complain!
| # expect { dispatcher.dispatch(event_name: event_name) }.to output(/before/).to_stdout | ||
| # end | ||
| # end | ||
| # end |
There was a problem hiding this comment.
forgot to delete them, was just to save some work 😅
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7