Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animation when toggling Headers and Payload #62

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Add animation when toggling Headers and Payload #62

merged 1 commit into from
Sep 21, 2016

Conversation

bernardlee
Copy link
Collaborator

Call slideToggle() on body in toggleBody() instead of .toggle().

Call slideToggle() on body in toggleBody() instead of .toggle().
@bernardlee
Copy link
Collaborator Author

bernardlee commented Sep 19, 2016

I spent a bit of time playing with CSS animations, with and without JavaScript, and it turns out that jQuery has built-in slide animation methods.

@ddavison ddavison merged commit dcc7a48 into ddavison:master Sep 21, 2016
@ddavison
Copy link
Owner

fantastic! thanks!

@javaguirre, you ok if I add @bernardlee as a contributor?

@javaguirre
Copy link
Contributor

Sure! Go ahead! :-D

On Wed, Sep 21, 2016, 03:46 Dj notifications@github.com wrote:

fantastic! thanks!

@javaguirre https://github.com/javaguirre, you ok if I add @bernardlee
https://github.com/bernardlee as a contributor?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#62 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAd0bPNxkarq2TrDuDAdr1J47__od6uWks5qsIx7gaJpZM4KA5CW
.


Javier Aguirre
https://javaguirre.net

@ddavison
Copy link
Owner

you're invited as a collaborator @bernardlee , thanks very much for helping out! keep it up

@bernardlee
Copy link
Collaborator Author

bernardlee commented Sep 22, 2016

Thank you.

@bernardlee bernardlee deleted the animation branch September 22, 2016 18:03
@ddavison
Copy link
Owner

if you think of an improvement of any kind, go ahead and push it up, and i'll review before publishing it to atom.io ;) feel free to push to master

@bernardlee
Copy link
Collaborator Author

If I think of any new improvements, then I'll add them to a separate branch for review. I don't want to break something by accident! Thanks again.

@bernardlee bernardlee restored the animation branch October 7, 2016 08:46
@bernardlee bernardlee deleted the animation branch October 7, 2016 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants