File extensions #66
Merged
File extensions #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddavison
approved these changes
Oct 10, 2016
javaguirre
reviewed
Oct 10, 2016
| editor.open() | ||
|
|
||
| constructFileName: -> | ||
| extension = mime.extension(@lastResponse.headers['content-type']); |
| editor.open() | ||
|
|
||
| constructFileName: -> | ||
| extension = mime.extension(@lastResponse.headers['content-type']); | ||
| "#{@lastRequest.method} #{@lastRequest.url}#{'.' + extension if extension}" |
There was a problem hiding this comment.
This is kind of unreadable, could you rewrite it in a way It's easier to read? Thank you! :-)
There was a problem hiding this comment.
Nevermind, I think It's fine this way 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the Open in separate editor feature.
This adds an ability of inferring the appropriate file extension basing on the response Content-Type. The most important point is that this allows Atom to highlight the file nicely and makes working with it easier. (Quiet related with #37.)
I also moved the option to the top as it's really frustrating to scroll down when the response is huge. Here's how it looks now: