Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LyricsX needs to be restarted after each song #581

Open
Ein-Tim opened this issue Sep 8, 2022 · 71 comments
Open

LyricsX needs to be restarted after each song #581

Ein-Tim opened this issue Sep 8, 2022 · 71 comments

Comments

@Ein-Tim
Copy link

Ein-Tim commented Sep 8, 2022

Environment

  • macOS Monterey 12.5.1
  • MacBook Air late 2020 (M1)
  • LyricsX version 1.6.3
  • Spotify for macOS (Apple Silicon) 1.1.93.896.g3ae3b4f3

Describe the bug

When I start LyricsX before I start playing a song, LyricsX won't work (=won't show the lyrics). So I start LyricsX while I play a song and it will work. However, after the currently playing song ended and the next one starts, LyricsX again doesn't work and needs to be restarted.

@RockTraveler
Copy link

I got same situation, i belive it's a bug.

@arifth
Copy link

arifth commented Sep 19, 2022

i got the same issue , need to restart lyricx after every song

@JosMurray
Copy link

I have the same problem than @Ein-Tim:
macOS 12.6
LyricsX App Store Version 1.6.3 (2350)
Spotify para macOS (Intel) 1.1.94.870.gf994cb0b

@sahakaori
Copy link

macOS 12.6
LyricsX App Store Version 1.6.3
iTunes also can't search Lyrics

@LLuna-a
Copy link

LLuna-a commented Sep 25, 2022

I have the same issue too
macos 12.6
Apple M1

@rzb-y
Copy link

rzb-y commented Sep 28, 2022

@ddddxxx It seems like the author is currently unavailable, and hasn't been responding to any messages sadly. I think almost everyone has this issue no matter which version

@LLuna-a
Copy link

LLuna-a commented Sep 28, 2022

i wrote an applescript that restarts it every 15 seconds if anyone interested i can post it

@eiche77
Copy link

eiche77 commented Sep 30, 2022

@LLuna-a it would be appreciated if you post the scripts. :)

@LLuna-a
Copy link

LLuna-a commented Sep 30, 2022

@LLuna-a it would be appreciated if you post the scripts. :)

@eiche77 https://github.com/LLuna-a/LyricsX-Temporary-Fix
here I published it it's not efficient at the moment I will rework it to simply restart it beginning of a new song

@LLuna-a
Copy link

LLuna-a commented Sep 30, 2022

also, @eiche77 if you understand the apple script can you help it with the more developed version I couldn't find a way to loop it it just works once and stops

@LLuna-a
Copy link

LLuna-a commented Oct 10, 2022

any news from the developer? can someone talk to him on telegram?

@Ein-Tim
Copy link
Author

Ein-Tim commented Oct 13, 2022

@ddddxxx Can we expect a fix for this issue from your side anytime soon?

@EraserCN
Copy link

The same issue for me.
Ventura beta 11

@RadioHeadach
Copy link

same

@augustido
Copy link

Same to me

@jjaychen1e
Copy link

jjaychen1e commented Nov 7, 2022

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map:
image

LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

@LLuna-a
Copy link

LLuna-a commented Nov 7, 2022

it seems like the problem is solved thanks to @jjaychen1e
edit: sadly it only works for the songs I listened to in the past (I don't know maybe it finds new ones but I tested in a couple of songs but it couldn't find some) it does not find new lyrics but can show old ones without restarting the app

@jjaychen1e
Copy link

it seems like the problem is solved thanks to @jjaychen1e
edit: sadly it only works for the songs I listened to in the past (I don't know maybe it finds new ones but I tested in a couple of songs but it couldn't find some) it does not find new lyrics but can show old ones without restarting the app

It's not merged and released yet, did you test it with your own build? For me, the cached lyrics work fine all the time, only new songs cannot fetch the lyrics. My commit fixes this but has not been merged.

@LLuna-a
Copy link

LLuna-a commented Nov 7, 2022

it seems like the problem is solved thanks to @jjaychen1e
edit: sadly it only works for the songs I listened to in the past (I don't know maybe it finds new ones but I tested in a couple of songs but it couldn't find some) it does not find new lyrics but can show old ones without restarting the app

It's not merged and released yet, did you test it with your own build? For me, the cached lyrics work fine all the time, only new songs cannot fetch the lyrics. My commit fixes this but has not been merged.

sorry, yes I tried building my own must made a mistake its worth waiting the official merge then
cached ones always had worked for me but it cached the first 2 3 ones I opened that's why i thought it worked

@Gghyy
Copy link

Gghyy commented Nov 10, 2022

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image

LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你!
Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

@jjaychen1e
Copy link

jjaychen1e commented Nov 10, 2022

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image
LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected.
LyricsX.app.zip

Update: I've re-uploaded a universal version so it can work on both Intel and Apple Silicon Macs.

@FrankYip1020
Copy link

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image
LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

@Gghyy
Copy link

Gghyy commented Nov 11, 2022

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image
LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Thank you very much!! That helps me a lot! 😄 😄

@jjaychen1e
Copy link

jjaychen1e commented Nov 11, 2022

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image
LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

Here is the universal version:

LyricsX.app.zip

@FrankYip1020
Copy link

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image
LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

Here is the universal version:

LyricsX.app.zip

Thanks a lot, it works on my Mac.

@Jechin
Copy link

Jechin commented Nov 11, 2022

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

@jjaychen1e
Copy link

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Sorry, it's my mistake. I turn off other services when debug the code. Here is the updated version:
LyricsX.app.zip

@LLuna-a
Copy link

LLuna-a commented Nov 11, 2022

thanks for new build it works

@timeblue8
Copy link

The same issue for me.
Ventura 13.1

@CharlesHim
Copy link

@ddddxxx The second and later responses from NetEase won't contain the Set-Cookie field in the header, so the compactMap just makes the publisher finish. We should change it to a normal map: image
LyricsKit's 0.11.3 version(which is required by the latest version of LyricsX) is not included in any branches. I've created a PR based on the master branch: ddddxxx/LyricsKit#16

你好,感谢你解决这个问题。请问你可以告诉我如何在电脑上修改这里的代码吗?因为我不太懂代码,我下载了lyricskit 的code,但是它和lyricsX好像没法关联到一起。我在lyricsX的文档里(右键显示包内容以及下载作者放出的源代码里)也没有找到和你提到的这段代码相关的地方。感谢你! Hi, thank you for solving this problem. But could you please tell me how to change the code in lyricsX? I don’t know CS very well, I downloaded the lyricsKit, but it can’t work when I open lyricsX. I don’t know how to make it work, I also can’t find something related to the code you wrote in the files of lyrics. Thank you !

You can download the fixed version here. Note that it's not an official release, I build it in the debug mode with my Xcode, but it should work as expected. LyricsX.app.zip

Could you please upload a Universal app version? This only works on Apple Silicon.

Here is the universal version:

LyricsX.app.zip

First, thanks a lot for your fixed version! It works!

However I noticed that your fixed version doesn't seem to support the feature "Auto Launch & Quit with music player". (Ventura 13.2.1, Mac mini with M2 chip)

After my attempts, I found the probable reason:

Allow Background

After I uninstall the original version and install the fixed version, the app should have been here when turn on the feature, which is probably used to support the feature (but the fixed app didn't appear here). So I think this may be the reason why the feature didn't work.

@assdssao
Copy link

@ervindobri Take a look at https://support.apple.com/en-gb/guide/mac-help/mchleab3a043/mac

非常感谢!!这非常有效的解决了我所有问题

@myleo1
Copy link

myleo1 commented Mar 17, 2023

ervices when debug the code. Here is the updated version: LyricsX.app.zip

thanks a lot but it doesn't work on MacOS 10.14 or older.

This version supports macOS 10.13 or newer: LyricsX.app.zip

It works fine on Monterey 12.5 M1 chip, Thanks a lot! 👍

@HelloApeBoy
Copy link

thx a lot.

@StrangerFory
Copy link

非常感谢,您的重构版本在13.3版本中也是工作的很好,向您学习。

@Mrered
Copy link

Mrered commented Apr 10, 2023

“自动启动和退出音乐播放器”功能似乎不起作用?

我也有此问题

@SergioGeeK7
Copy link

Awesome, thanks friend !

@JZQWQ
Copy link

JZQWQ commented Apr 21, 2023

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Sorry, it's my mistake. I turn off other services when debug the code. Here is the updated version: LyricsX.app.zip

您好,感谢您的更新!但它仍然没有解决,依旧只能搜到163的歌词。Hello, thanks for the version! But it's still not solved, still only can search 163 lyrics.

@JYvracle
Copy link

Hi, I'm still facing the same question. I use Spotify in US. My computer is M1 pro Ventura 13.2.1. I wish to have lyrics with Chinese translation. The Search window is able to open but cannot show any results, even if sometime there are lyrics showing below. I can see there are several lyrics are from Tencent (QQ) but I'm not sure where is the exact source from. It worked very well before I changed to this computer since the end of 2021. And I cannot open the software from the zip above. I really rely on this app. I hope it can be fixed! Thank you so much!

@Mx-Iris
Copy link

Mx-Iris commented Jun 7, 2023

我修复了,目前能搜到3个来源,(QQ,网易,酷狗),QQ因为API的原因只能搜到最匹配的一首歌,已经提了PR,作者似乎已弃坑,我看看后面能不能接手这个项目,如果下面这个下载了打不开请尝试开启未知来源,还是打不开可以回复我
iShot_2023-06-07_23 56 09

LyricsX 2023-06-08 00-00-31.zip

@JYvracle
Copy link

JYvracle commented Jun 7, 2023

您好,非常感谢您的回复。我刚才下载了你这个zip文件但是没有办法打开,已经在设置里面手动允许打开软件,但是还是显示不能打开,不知道您是否可以帮忙解决问题。
Screenshot 2023-06-08 at 00 33 51

@Mx-Iris
Copy link

Mx-Iris commented Jun 8, 2023

您好,非常感谢您的回复。我刚才下载了你这个zip文件但是没有办法打开,已经在设置里面手动允许打开软件,但是还是显示不能打开,不知道您是否可以帮忙解决问题。 Screenshot 2023-06-08 at 00 33 51

可能是我没有用开发者帐号签名,我下班回家后再打个包。

@Mx-Iris
Copy link

Mx-Iris commented Jun 8, 2023

您好,非常感谢您的回复。我刚才下载了你这个zip文件但是没有办法打开,已经在设置里面手动允许打开软件,但是还是显示不能打开,不知道您是否可以帮忙解决问题。 Screenshot 2023-06-08 at 00 33 51

LyricsX.zip

@JYvracle
Copy link

JYvracle commented Jun 9, 2023

您好,可以使用了,也有QQ音乐的歌词。非常感谢!

@Bill-Haku
Copy link

您好,非常感谢您的回复。我刚才下载了你这个zip文件但是没有办法打开,已经在设置里面手动允许打开软件,但是还是显示不能打开,不知道您是否可以帮忙解决问题。 Screenshot 2023-06-08 at 00 33 51

LyricsX.zip

@Mx-Iris Can you share the source code after you have fixed this issue? I tried but failed to find a repo in your profile.

@Mx-Iris
Copy link

Mx-Iris commented Jun 15, 2023

您好,非常感谢您的回复。我刚才下载了你这个zip文件但是没有办法打开,已经在设置里面手动允许打开软件,但是还是显示不能打开,不知道您是否可以帮忙解决问题。 Screenshot 2023-06-08 at 00 33 51

LyricsX.zip

@Mx-Iris Can you share the source code after you have fixed this issue? I tried but failed to find a repo in your profile.

ddddxxx/LyricsKit#20
只更改了LyricsKit,其他没有变,注意在LyricsX中所使用的是0.11.0版本,而不是master分支

@JamesBaiyong
Copy link

The source of the lyrics is only NetEase, there is no QQ and Kugou, can this be solved?

Sorry, it's my mistake. I turn off other services when debug the code. Here is the updated version: LyricsX.app.zip

非常感谢🙏

@HotSharkkkk
Copy link

我修复了,目前能搜到3个来源,(QQ,网易,酷狗),QQ因为API的原因只能搜到最匹配的一首歌,已经提了PR,作者似乎已经弃坑,我后面看看能不能接手这个项目,如果下面这个下载了打不开请尝试未知来源,还是打不开可以回复我 iShot_2023-06-07_23 56 09>> 歌词X 2023-06-08 00-00-31.zip感谢修复🙏,如果后期有时间希望可以帮忙看看鼠标移入自动隐藏在macOS13及以上无法生效的问题

@zwrong
Copy link

zwrong commented Sep 2, 2023

您好,非常感谢您的回复。我刚才下载了你这个zip文件但是没有办法打开,已经在设置里面手动允许打开软件,但是还是显示不能打开,不知道您是否可以帮忙解决问题。 Screenshot 2023-06-08 at 00 33 51

LyricsX.zip

macOS Ventura 13.4.1 (c)
MacBook pro 2021 (M1 pro)
现在可以正常使用了,非常感谢你!Thanks!

@zwrong
Copy link

zwrong commented Sep 2, 2023

您好,非常感谢您的回复。我刚才下载了你这个zip文件但是没有办法打开,已经在设置里面手动允许打开软件,但是还是显示不能打开,不知道您是否可以帮忙解决问题。 Screenshot 2023-06-08 at 00 33 51

LyricsX.zip

macOS Ventura 13.4.1 (c) MacBook pro 2021 (M1 pro) 现在可以正常使用了,非常感谢你!Thanks!

您好,我发现鼠标悬停隐藏功能还是实现不了,看到别人也有这个问题,可以麻烦您修复一下这个BUG吗?没有空也没有关系,现在的版本已经很好用了,感谢你修复这个需要重新启动的BUG。

@suboyang
Copy link

suboyang commented Sep 2, 2023

#581 (comment)
这个版本还更新audirvāna studio版本的支持吗?

@Elena-Xiao
Copy link

我修复了,目前能搜到3个来源,(QQ,网易,酷狗),QQ因为API的原因只能搜到最匹配的一首歌,已经提了PR,作者似乎已弃坑,我看看后面能不能接手这个项目,如果下面这个下载了打不开请尝试开启未知来源,还是打不开可以回复我 iShot_2023-06-07_23 56 09

LyricsX 2023-06-08 00-00-31.zip

你好我还是无法打开这个app 🥹

@Mx-Iris
Copy link

Mx-Iris commented Oct 1, 2023

我修复了,目前能搜到3个来源,(QQ,网易,酷狗),QQ因为API的原因只能搜到最匹配的一首歌,已经提了PR,作者似乎已弃坑,我看看后面能不能接手这个项目,如果下面这个下载了打不开请尝试开启未知来源,还是打不开可以回复我 iShot_2023-06-07_23 56 09
LyricsX 2023-06-08 00-00-31.zip

你好我还是无法打开这个app 🥹

https://github.com/JH-Application-Forks/LyricsX/releases/tag/v1.6.4

@Elena-Xiao
Copy link

我修复了,目前能搜到3个来源,(QQ,网易,酷狗),QQ因为API的原因只能搜到最匹配的一首歌,已经提了PR,作者似乎已弃坑,我看看后面能不能接手这个项目,如果下面这个下载了打不开请尝试开启未知来源,还是打不开可以回复我 iShot_2023-06-07_23 56 09

LyricsX 2023-06-08 00-00-31.zip

你好我还是无法打开这个app 🥹

https://github.com/JH-Application-Forks/LyricsX/releases/tag/v1.6.4

完美解决 感谢(❁´ω`❁)!

@Shawnzahk
Copy link

偏好设置里面实验室功能 合并图标和歌词功能 感觉有bug 歌词刚出现的时候总是有省略号 @Mx-Iris

@AjianNie
Copy link

AjianNie commented Dec 3, 2023

我修复了,目前能搜到3个来源,(QQ,网易,酷狗),QQ因为API的原因只能搜到最匹配的一首歌,已经提了PR,作者似乎已弃坑,我看看后面能不能接手这个项目,如果下面这个下载了打不开请尝试开启未知来源,还是打不开可以回复我 iShot_2023-06-07_23 56 09
LyricsX 2023-06-08 00-00-31.zip

你好我还是无法打开这个app 🥹

https://github.com/JH-Application-Forks/LyricsX/releases/tag/v1.6.4

您好, 目前用Spotify播放, 歌词偏移很严重也很奇怪.
Intel macOS13.6, LyricsX为您发布的v1.6.4

稳定复现: 歌词显示一般都会提前, 手动搜索歌词加载(已根据起始人声选择歌词--确保歌词版本选择正确), 此时后退若干秒, 歌词显示时间又正常了...

已尝试: 重启/重装LyricsX 1.6.4, 重启电脑

LyricsX所有配置基本为默认, 只改了歌词颜色.

如果有需要协助排查, 麻烦您联系我hongye320721@gmail.com

@aviwad
Copy link

aviwad commented Nov 21, 2024

If anyone is still looking for an up to date menubar/karaoke lyrics app, please try my app Lyric Fever. (lyricfever.com). LyricsX was my inspiration and I have improved on it in many ways. 10x more CPU efficient too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests