Add a terminal UI lyrics player #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
suransea
commented
Jul 15, 2021
suransea
commented
ddddxxx
requested changes
Jul 23, 2021
README.md
Outdated
| | , | previous track | | ||
| | . | next track | | ||
|
|
||
|  |
There was a problem hiding this comment.
commit this image? probably Resources/example_1.png
| var onSeek: ((Int, Int) -> Void)? | ||
| var onState: ((PlaybackState) -> Void)? | ||
|
|
||
| private(set) var lines: [LyricsLine] = [] |
There was a problem hiding this comment.
why [LyricsLine] instead of Lyrics? note a Lyrics instance also carries lyrics offset, which you didn't respect.
| .store(in: &tickCancelBag) | ||
| } | ||
|
|
||
| private func index(of offset: TimeInterval) -> Int { |
Sources/lyricsx-cli/LyricsXCli.swift
Outdated
Comment on lines
33
to
37
| #if os(macOS) | ||
| typealias PlayingPlayer = MusicPlayers.SystemMedia | ||
| #elseif os(Linux) | ||
| typealias PlayingPlayer = MusicPlayers.MPRISNowPlaying | ||
| #endif |
There was a problem hiding this comment.
create a new subclass of MusicPlayers.Agent and conditionally set its designatedPlayer.
Signed-off-by: sea <simpleslight@icloud.com>
Signed-off-by: sea <simpleslight@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.