Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add VCS support #73

Merged
merged 2 commits into from
Mar 1, 2022
Merged

✨ Add VCS support #73

merged 2 commits into from
Mar 1, 2022

Conversation

ddelange
Copy link
Owner

@ddelange ddelange commented Mar 1, 2022

Closes #61

Adds support for VCS and PEP 440 direct references:

pipgrip "requests[socks] @ git+https://github.com/psf/requests"
pipgrip "requests[socks] @ https://github.com/psf/requests/releases/download/v2.27.1/requests-2.27.1-py2.py3-none-any.whl"
  • Treat a VCS requirement (parsed by pkg_resources into the url attr) as a unique identifier, as pip also doesn't perform resolving on different VCS urls that would resolve to the same code.
  • As pkg_resources only successfully parses VCS when the @ is present, this is not edge-cased in this PR. It is noted in the known caveats section.
  • pkg_resources fails to parse @ -e svn+. It is not edge-cased in this PR. It is noted in the known caveats section.
  • Adding support for (local) paths/URLs other than . is not in scope of this PR

@ddelange ddelange merged commit fe894a4 into master Mar 1, 2022
@ddelange ddelange deleted the vcs-support branch March 1, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement VCS support
1 participant