Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for queries #24

Merged
merged 12 commits into from
Jul 8, 2020
Merged

Conversation

s-weigand
Copy link
Contributor

Since the recent changes in the GitHub websites markup broke this extension again (thx for the quick fix ❤️), IMHO it is a good idea to test for changes in the supported page's markup on schedule (i.e. daily).

The changes introduced by this PR are:

  • Added query tests for all supported pages, except PasteBin (couldn't find an example that fits)

  • Fixed problem with breadcrubs on GitHub when in a folder

    • Before:
      grafik
    • After:
      grafik
  • Fixed problems with BitBucket (selector + update event)

  • Activated SourceForge by default and added right margin for the icons

    • Before:
      grafik
    • After:
      grafik
  • Replaced travis CI with github actions (example CI output)

  • Made tests automatically upload build extensions
    grafik

The tests for GitLab and BitBucket are run using puppeteer, because the page is rendered by javascript and the queried elements aren't present if the page is only fetched.

@dderevjanik
Copy link
Owner

dderevjanik commented Jul 7, 2020

Wooow, I see plenty of improvements here... 👍
Everything looks great :) ! My only question is if its possible to automatically build artifcat (npm run build:prod) when I push tagged branch to git (for example rc-1.23) ?

@s-weigand
Copy link
Contributor Author

s-weigand commented Jul 7, 2020

Atm the CI it builds the artifacts on push, PR and on schedule (tag is also counted as push as far as I know).
But there are also actions to publish extensions for chrome and firefox (not sure about opera), which you can setup to do so on tags.
I publish my extension on tag push cia the CI.
If you want I can add a seperate workflow for publishing on tag push, the guide on how to get all API keys can be found here.

@s-weigand s-weigand force-pushed the add-dom-tests branch 3 times, most recently from 0ebcaa1 to db5a105 Compare July 7, 2020 23:08
@dderevjanik dderevjanik merged commit 3470130 into dderevjanik:master Jul 8, 2020
@s-weigand s-weigand deleted the add-dom-tests branch July 10, 2020 06:07
@s-weigand s-weigand mentioned this pull request Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants