Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github-url-detection #26

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Use github-url-detection #26

merged 2 commits into from
Oct 15, 2020

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Aug 8, 2020

github-url-detection is extracted from the Refined GitHub so there is no need to use copied code anymore.

@codecov-commenter
Copy link

Codecov Report

Merging #26 into master will decrease coverage by 0.53%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   16.79%   16.26%   -0.54%     
==========================================
  Files          19       19              
  Lines         393      369      -24     
  Branches       53       50       -3     
==========================================
- Hits           66       60       -6     
+ Misses        325      307      -18     
  Partials        2        2              
Impacted Files Coverage Δ
packages/content/utils/PageDetect.ts 77.77% <50.00%> (+36.60%) ⬆️
packages/content/pages/GistGitHub.ts 37.50% <100.00%> (ø)
packages/content/pages/GitHub.ts 15.62% <100.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3470130...e6a557d. Read the comment docs.

@dderevjanik dderevjanik merged commit 01e4405 into dderevjanik:master Oct 15, 2020
@kidonng
Copy link
Contributor Author

kidonng commented Oct 15, 2020

@kidonng this is already part of #27, Am I right ?

This is not included in #27 because it's a minimal change.

@dderevjanik
Copy link
Owner

sorry I misread that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants