Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make add-on work w/o ddev-router, update tests, fixes #25 #26

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Make add-on work w/o ddev-router, update tests, fixes #25 #26

merged 1 commit into from
Aug 2, 2024

Conversation

stasadev
Copy link
Member

The Issue

How This PR Solves The Issue

In terms of functionality, this add-on is similar to https://github.com/ddev/ddev-phpmyadmin
This PR contains recent fixes and improvements from ddev-phpmyadmin.

Manual Testing Instructions

Test it locally and in Gitpod.

Open in Gitpod

ddev get https://github.com/ddev/ddev-adminer/tarball/20240718_stasadev_norouter
ddev restart
ddev adminer

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

rfay
rfay approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks.

@rfay rfay merged commit eb6453d into main Aug 2, 2024
2 checks passed
@rfay rfay deleted the 20240718_stasadev_norouter branch August 2, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasadev @rfay