Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ddev quickstart command #87

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: ddev quickstart command #87

wants to merge 4 commits into from

Conversation

hanoii
Copy link
Contributor

@hanoii hanoii commented Oct 21, 2024

This is my take into a single command for the contrib init.

Add a quickstart command that does everything that's needed to be done for getting the project up and running instead of manually following the steps.

Adds tests

Fixes #15

@hanoii
Copy link
Contributor Author

hanoii commented Oct 21, 2024

Ok, this is interesting and thanks to the tests I caught this early...

The whole ddev config --update becomes a chicken and egg problem. Because when one sets this up initially for a new module, or even when you clone a module that has this already setup, there's no codebase on the module, which means. that ddev poser will just fail because d11 requires php 8.3.

While I am keeping that here, if this approach of having a quickstart command is desired which I hope because it's simple I'd suggest removing the need for ddev config --auto or maybe better provide an override of the drupal version through command line on ddev so that one can tell ddev to set its own defaults for the drupal core even if no core is detected.

@hanoii
Copy link
Contributor Author

hanoii commented Oct 21, 2024

So most of the times this will not be an issue. Obviously downgrading this to an older core might cause issues but that was going to always be the case.

Let me know your thoughts on something like this

@weitzman
Copy link
Collaborator

IMO its a bit too much code to maintain. I'd just as soon stick with current docs approach. Happy to discuss more.

@hanoii
Copy link
Contributor Author

hanoii commented Oct 23, 2024

I am not too convinced on this approach, but I am on the idea of having something like this as part of the addon. What I would actually would like, is that this same code would be able to switch core easily with the sensible defaults.

Right now in my mind my next steps around this idea would be to change the command into something like ddev init or ddev contrib:init with a drupal core argument so that one could easily switch cores, removing everything and reinstalling.

This is something I would like to have in such a ddev, but I don't want to spend a ton of time going around this is this is not something you'd consider accepting, so let me know if you want to discuss further.

I also offer to help maintaining this add-on.

@weitzman
Copy link
Collaborator

That command sounds useful. I would weigh its usefulness against the maint burden of it. I'm not sure how to decision would end up. https://github.com/ddev/ddev-drupal-contrib?tab=readme-ov-file#changing-the-drupal-core-version describes the current steps and they look simple enough to me that I'm not sure we should ship a command for it.

@weitzman weitzman added the enhancement New feature or request label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide single-command setup documentation
2 participants