-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ddev quickstart command #87
base: main
Are you sure you want to change the base?
Conversation
Ok, this is interesting and thanks to the tests I caught this early... The whole While I am keeping that here, if this approach of having a quickstart command is desired which I hope because it's simple I'd suggest removing the need for |
So most of the times this will not be an issue. Obviously downgrading this to an older core might cause issues but that was going to always be the case. Let me know your thoughts on something like this |
IMO its a bit too much code to maintain. I'd just as soon stick with current docs approach. Happy to discuss more. |
I am not too convinced on this approach, but I am on the idea of having something like this as part of the addon. What I would actually would like, is that this same code would be able to switch core easily with the sensible defaults. Right now in my mind my next steps around this idea would be to change the command into something like This is something I would like to have in such a ddev, but I don't want to spend a ton of time going around this is this is not something you'd consider accepting, so let me know if you want to discuss further. I also offer to help maintaining this add-on. |
That command sounds useful. I would weigh its usefulness against the maint burden of it. I'm not sure how to decision would end up. https://github.com/ddev/ddev-drupal-contrib?tab=readme-ov-file#changing-the-drupal-core-version describes the current steps and they look simple enough to me that I'm not sure we should ship a command for it. |
This is my take into a single command for the contrib init.
Add a quickstart command that does everything that's needed to be done for getting the project up and running instead of manually following the steps.
Adds tests
Fixes #15