feat(*): Add redis-commander command #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienloizelet
commented
Oct 23, 2024
| @@ -0,0 +1,23 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I've tried to avoid hard-coding the PORTs. (like in phpmyadmin or xhgui). But I don't know if my implementation may have side effects or not.
There was a problem hiding this comment.
I like it.
We have this issue:
I think something similar can be done with golang in the future.
stasadev
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Looks good to me, thank you!
I tested a regular setup and then did the same in Gitpod with:
ddev add-on get ddev/ddev-redis
ddev add-on get https://github.com/julienloizelet/ddev-redis-commander/tarball/feat/redis-commander-command
ddev restart
ddev redis-commander
| @@ -0,0 +1,23 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I like it.
We have this issue:
I think something similar can be done with golang in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
This PR follows this comment: #17 (comment)
I've also updated the README with up to date information.
How This PR Solves The Issue
It adds a
ddev redis-commandercommand to launch the Web interface easily.Manual Testing Instructions
Automated Testing Overview
I've added a test for the command
Related Issue Link(s)
Release/Deployment Notes