Use default DDEV database

[tyler36]

This PR

• uses the default DDEV database
• removes Mongo as a dependency.

PDO does NOT have feature parity with MongoDB, see Compatibility matrix.
Not sure if PDO or MongoDb should be default.

See #16.

[rfay]

I think it would be better to use a separate database, perhaps named xhgui? In general, the actual database should probably only contain project information.

[rfay]

I like it.

[tyler36]

Not sure if it's better to nudge people to update docker-compose.xhgui.yaml or xhgui.config.php?
We pass environmental through docker-compose so these are DDEV-prefered fallbacks.

[rfay]

I don't recommend having them touch either one. Why would we have them change any file? xhgui's files can create the db if it doesn't exist, and use the special db. The only problem, as you mentioned elsewhere, might be postgres. It doesn't know how to use postgres?

[tyler36]

While testing, I discovered that ${DDEV_DATABASE_FAMILY} does not work for postgres.

The original PR (mine) sets DDEV_DATABASE_FAMILY as follows:

• Defaults to mysql
• Set to postgres if database is postgres

This is in line with official connection strings: https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING
EG. postgresql://user:secret@localhost

However, when using PHP DSN strings, such as xhgui uses, it requires pgsql
Eg. psql:host=db;dbname=xhgui

[tyler36]

OK this looks ready to me.

It dynamically sets the database and includes functions tests for each.

• mariadb
• mysql
• postgres

[rfay]

This probably needs removal_actions in the install.yaml to remove the new database when the add-on is uninstalled.

Thanks for the great work on this!

[rfay]

Manually testing with

ddev get https://github.com/tyler36/ddev-xhgui/tarball/20231121_use_ddev_database

[rfay]

It's a great improvement, thanks! Tested OK. Looking forward to all the great improvements here.

[tyler36]

It now removes the XHGUI database on removal. Updated the tests for confirmation.

[rfay]

I took it for a spin, but now nothing seems to happen at all. I installed this PR, did ddev xhprof on, visited a few pages, and still see "Looks like you haven't done any profiling"

select * from watches; and select * from results; both show no rows.

[rfay]

Oh, sorry. I guess I have to change Drupal configuration to make it work at all.

Sometimes these PRs and issues run too long! :)

[rfay]

Now it works, since I followed the instructions.

A future improvement might be to figure out a way to tell people "You haven't done the configuration".

Optionally adding the configuration the way ddev-redis does for Drupal would be a thing to consider.

[rfay]

This works great! Removal works great, except the xhprof_prepend, which is elsewhere.

Future improvements may include coaching people if they haven't done necessary pre-configuration, as you have to do for Drupal, etc.