Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Use Stdin for tty detection, fixes #1690 #1700

Merged
merged 2 commits into from
Jul 10, 2019
Merged

[FIX] Use Stdin for tty detection, fixes #1690 #1700

merged 2 commits into from
Jul 10, 2019

Conversation

dasjoe
Copy link
Contributor

@dasjoe dasjoe commented Jul 9, 2019

Fixes #1690

Related to mattn/go-isatty#38

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rfay
Copy link
Member

rfay commented Jul 9, 2019

Cool, looking forward to trying it! This will need a test in the import-db test.

@rfay
Copy link
Member

rfay commented Jul 9, 2019

The current test failure is a result of an external dependency being down, doesn't have anything to do with this PR.

rfay
rfay approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fantastic, works out of the box. What a great improvement, thanks for the research and fix. I'll just add a bit to the test and it should be good to go.

@rfay
Copy link
Member

rfay commented Jul 10, 2019

So great; I added a little test coverage, and this can come in when it's green.

@rfay rfay changed the title [FIX] Use Stdin for tty detection [FIX] Use Stdin for tty detection, fixes #1690 Jul 10, 2019
@rfay rfay merged commit 93ea28d into ddev:master Jul 10, 2019
@rfay
Copy link
Member

rfay commented Jul 10, 2019

Thanks so much for this excellent contribution!

@rfay rfay mentioned this pull request Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ddev import-db should accept data from /dev/stdin
3 participants
@dasjoe @CLAassistant @rfay