Don't allow Let's Encrypt with Traefik router, fixes #4632 #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfay
force-pushed
the
20230223_traefik_use_lets_encrypt
branch
from
0461a33 to
f1a93e2
Compare
rfay
force-pushed
the
20230223_traefik_use_lets_encrypt
branch
from
f1a93e2 to
6e583dd
Compare
|
Download the artifacts for this pull request: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Don't allow this configuration; however, it can be configured with custom traefik config
Manual Testing Instructions
Try to configure let's encrypt with traefik. Should fail. Read docs.
Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes