-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Rescue intentional line breaks #4763
Conversation
# Conflicts: # docs/content/developers/writing-style-guide.md # docs/content/users/debugging-profiling/step-debugging.md # docs/content/users/install/ddev-installation.md # docs/content/users/install/shell-completion.md # docs/content/users/topics/hosting.md # docs/content/users/usage/architecture.md # docs/content/users/usage/cms-settings.md # docs/content/users/usage/database-management.md # docs/content/users/usage/developer-tools.md # docs/content/users/usage/troubleshooting.md
Sorry if I'm being dense, but if trim_trailing_whitespace makes us dance around with Normal markdown treats double linefeeds with respect. We'd rather have "normal" markdown. Am I lost still? |
I brought this up here, reiterated again why This is that PR. The If you want me to drop |
I'm the one that thinks trailing whitespaces do no harm. I apologize about this confusion, but I never thought this was a problem that needed solving. I guess we all think we're not being listened to. Do you think the trailing spaces is even a problem that needs solving? Does anybody but @gilbertsoft think it's a problem that needs solving? |
Not in Markdown, no. But I can’t speak for the whole codebase or @gilbertsoft’s intentions—just defending my precious line breaks. |
Except for the `<br>` elements in table cells.
@rfay Updated my approach here along with the description. Ready to review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we feel the pain receding?
The Issue
.editorconfig
improvements in #4712 strip trailing spaces, which in Markdown removes two-space line endings (<br>
elements.How This PR Solves The Issue
This removes the problematic
trim_trailing_whitespace = true
setting, re-adds two-space line endings that have since been stripped out of Markdown files, and fixes some other mangled spacing I noticed along the way.The result allows Markdown to continue operating like someone would expect, without needing to resort to using
breaks stripped on save.
<br>
elements all over the place or unwittingly having theirManual Testing Instructions
Preview changes locally or inspect the automatic build.
Automated Testing Overview
n/a
Related Issue Link(s)
Release/Deployment Notes
n/a