fix: return MTU 1440 for Gitpod, fixes #5611

[stasadev]

The Issue

• In Gitpod docker network needs MTU 1440 #5611

This is a regression.

How This PR Solves The Issue

The project's network is created programmatically and the MTU value is not set, since it is declared only in the docker-compose.yaml file and there is no way to modify the network after it is created.

This PR returns the MTU value with a small refactoring.

Manual Testing Instructions

I don't know if this PR can be checked directly in Gitpod, so my way to check is:

1. Checkout this PR locally
2. Modify the source code to reverse the check for Gitpod, look at this change:

if nodeps.IsGitpod() {
    netOptions.Options = map[string]any{
        "com.docker.network.driver.mtu": "1440",
    }
}

Add ! to nodeps.IsGitpod():

if !nodeps.IsGitpod() {
    netOptions.Options = map[string]any{
        "com.docker.network.driver.mtu": "1440",
    }
}

3. make build
4. ddev start
5. docker inspect ddev-project-name_default should contain this:

"Options": {
    "com.docker.network.driver.mtu": "1440"
},

Automated Testing Overview

Related Issue Link(s)

Release/Deployment Notes

Probably release a new Gitpod image after this PR goes to master (since this bug breaks Gitpod).

[github-actions]

Download the artifacts for this pull request:

• all-ddev-executables.zip
• ddev-linux-amd64.zip
• ddev-linux-arm64.zip
• ddev-macos-amd64.zip
• ddev-macos-arm64.zip
• ddev-windows-amd64-installer.zip

See Testing a PR

[stasadev]

Why I added labels here:

This is a small addition to clean up the project network during ddev poweroff.

Some external programs (such as PhpStorm) can call docker-compose up with this template:

• Since using the plugin, I am getting a lot of orphaned networks and failed ddev starts php-perfect/ddev-intellij-plugin#263 (comment)

And in this case, when you do a ddev poweroff, the project network created by docker-compose is not removed because it has no label.

[rfay]

Please take a look at the history on this and check it. It seems like we had to "wire" the MTU earlier. Do you remember this @shaal ?

Anyway review of issues and commits should show it.

[rfay]

I thought we already fiddled with gitpod mtu.

[mk-mxp]

@rfay Yes, you did: #3766. But that writes it to docker-compose.yaml only. @stasadev rewrote the network launch to be handled by ddev without docker compose instead.

[shaal]

What I remember was that before we made a fix to MTU value, running composer on a Drupal website would get stuck on some packages.

…

On Tue, Dec 12, 2023, 6:23 AM mk-mxp ***@***.***> wrote: @rfay <https://github.com/rfay> Yes, you did: #3766 <#3766>. But that write it to docker-compose.yaml only. @stasadev <https://github.com/stasadev> rewrote the network launch to be handled by ddev without docker compose instead. — Reply to this email directly, view it on GitHub <#5612 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFS5MVPU5MGXTPWQHTAD3YJA5EFAVCNFSM6AAAAABANDGXYKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJRHA2DOMZUHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[stasadev]

Yeah, it's a regression.
I'm going to make a new point release in the next couple of days to fix Gitpod (and introduce other stuff, like Xdebug for php8.3).