Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Beast and Blacktee Redrawn #49

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Add Beast and Blacktee Redrawn #49

merged 6 commits into from
Oct 17, 2023

Conversation

M0REKZ
Copy link
Contributor

@M0REKZ M0REKZ commented Oct 17, 2023

SVGs for Beast and Blacktee

@def-
Copy link
Member

def- commented Oct 17, 2023

screenshot_2023-10-17_09-36-06
screenshot_2023-10-17_09-36-52
screenshot_2023-10-17_09-38-28
screenshot_2023-10-17_09-38-35
Looks about the same to me, maybe beast is 1 pixel less wide. Not sure if anything else has to be done or can be submitted now? @Jupeyy

@ChillerDragon
Copy link
Collaborator

Cool thanks @M0REKZ for contributing something ❤️

Next time please open an issue when you start working on it. So we can discuss stuff first before you spend time on it. Also to avoid two people working on the same texture.

image

Am I being too picky or could this be done cleaner?

Also it is not a vanilla skin. Not sure where and when it was introduced. But someone might have the original svg and might be willing to share it. As far as I know heinrich once managed to reach whis via the teeworlds forum.

@M0REKZ
Copy link
Contributor Author

M0REKZ commented Oct 17, 2023

Cool thanks @M0REKZ for contributing something ❤️

Next time please open an issue when you start working on it. So we can discuss stuff first before you spend time on it. Also to avoid two people working on the same texture.

Lol, i think didnt open one because was not sure if i would abandon this at the first second, but maybe next time i will open an issue.

(Image)

Am I being too picky or could this be done cleaner?

I was trying to replicate some white pixels above and below, in my opinion keeping these actually makes the eye nice looking, but maybe i could try to improve it if doesnt look ugly on 256x128

--
Captura de pantalla 2023-10-17 a la(s) 09 31 31
Captura de pantalla 2023-10-17 a la(s) 09 31 51

--

Also it is not a vanilla skin. Not sure where and when it was introduced. But someone might have the original svg and might be willing to share it. As far as I know heinrich once managed to reach whis via the teeworlds forum.

By seeing the ddnet commits, it was 10 years ago, and also i see that @mindTW Recreated like 50% of the Whis skins, however, if actually Whis decides to give the svg, that would be definitely better.

@ChillerDragon
Copy link
Collaborator

Okay if that was an intentional decision thats cool with me. LGTM
@Jupeyy any objections otherwise I would vote for merge.

@Jupeyy
Copy link
Member

Jupeyy commented Oct 17, 2023

Okay if that was an intentional decision thats cool with me. LGTM @Jupeyy any objections otherwise I would vote for merge.

not directly related to this commit, but i've seen, that for whis skins we added the license type. since black tee is not from whis and also not vanilla, we should either be strict and add it for this too, or we could also remove it from whis skins, since the license mentions the license.txt from ddnet repo anyway

dino, ghost, giraffe, greensward, greyfox, jeet, kintaro_2, mermydon, mermydon-coala,
nanami, random, voodoo_tee, whis:
Copyright Whis
Recreation by mind
CC-BY license

@ChillerDragon
Copy link
Collaborator

yes good catch lawyer jopsti we can also do this in a follow up pr

@Jupeyy Jupeyy merged commit 1d1ba49 into ddnet:main Oct 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants