Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check inkscape filename matching actual filename #57

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

ChillerDragon
Copy link
Collaborator

Added the optional dependency yq for xml parsing. But falls back to a 20 lines bash self rolled xml parser (what could possibly go wrong). There is no --fix that seemed to complex and error prone. So users have to fix it manually. That could potentially be annoying. We could also make it a warning instead of an error.

Also refactored all errors.

And structured the code into functions.

@Jupeyy
Copy link
Member

Jupeyy commented Mar 25, 2024

i guess for this project having no --fix is ok, but i'd also be ok with a warning instead.
it's maybe still nice to have this simply because looking in the fails it says for example grass_main_chiller. And having chiller in the name is way too swag.

but otherwise looks fine, not like i could read that stuff anyway

@ChillerDragon
Copy link
Collaborator Author

Yea cring I caused 50% of the current mismatches.

Okay let's go with warning I will do it later.

@ChillerDragon
Copy link
Collaborator Author

I turned it into a warning. The CI will pass if a wrong filename is detected. And I also fixed all warnings.

@Jupeyy Jupeyy merged commit a065be5 into ddnet:main Mar 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants