Use "Link" instead of "Links" for header extra #142
Conversation
|
ooops... my bad. For some reason I had a sort of mind-typo that made me read and write Links in place of Link everywhere! BTW I am not so sure about the naming of the other headers in #141. Is there any standard or should them be considered custom headers? Some recent gem use 'X-Total-Page' and 'X-Total-Count' and for custom headers the 'X-' prefix looks more correct to me. I think I am going to add a |
|
Checked the new head of feature/headers and paging now works as expected. There is nothing in the RFC regarding this. From what I've seen api-pagination gem uses The latter (prefixing Edit: Making this configurable seems like a good idea, so people switching to Pagy for their APIs don't have to rewrite their consuming apps, if those headers are called differently in the API pagination gems they have used. |
|
I was not aware of the deprecation link. Thank you! |
* added headers extra * Use "Link" instead of "Links" for header extra (#142) * added customizable headers; normalized hash and headers; code improvements; updated doc and tests
Just looked at the
READMEfor the headers feature and it really looked simple enough, so I couldn’t resist testing it.Purging the api-pagination gem and replacing the API stuff was really straight forward, simple and quick.
At first glance with Postman everything looked ok, so I started up an App in iOS Simulator that consumes the API and paging didn’t work.
So looking closer at the links Pagy injects, I saw that you use
instead of
I think it would be hard to justify changing Apps that consume the API(s) the headers extra could be used for and RFC 8288 (page 14) also uses Link like api-pagination, so you might reconsider this.